Closed LeSpocky closed 6 years ago
I just built the firmware with your PR. It worked fine. I also flashed it to a router, which also worked. I could connect to the router with my phone and my laptop, so I suppose, that your changes are fine.
Thanks for testing. Should we merge this for v0.38? I set milestone to v0.39 in the first place to have more time for testing the supported_rates
and basic_rate
options. I would have proposed to make a quick release v0.39 after v0.38 with changes like this.
I am not sure, if people would notice, that we disable 802.11b. I think, almost every device also supports the next 802.11g standard, dunno, if there are metrics about this. Gluon should test their options, so I would assume, that the setting itself is stable.
I would merge it ASAP.
I vote for merging in 0.39.
The current firmware is almost ready and has been tested for a while. We should roll-out before making more changes which, in turn, require re-testing.
The changes in the site.mk are redundant (came with the last firmware version). Maybe this part of the commit can be removed?
I just rebased on master.
The changes in the site.mk are redundant (came with the last firmware version). Maybe this part of the commit can be removed?
The intention of those changes (and of the whole PR) is to keep our files as close as possible to the files from site-example to simplify merging later upstream changes from the examples.
Gluon contains an example for the subfolder
site
belowdocs/site-example
. This merges not yet applied changes from the v2016.2.7 example to oursite.conf
andsite.mk
files.This introduces options
supported_rates
andbasic_rate
in filesite.conf
which "removes 802.11b compatibility for better performance".