search

FreifunkMD / site-ffmd

Freifunk Magdeburg specific Gluon configuration
Creative Commons Zero v1.0 Universal
2 stars 12 forks source link

Merge changes from gluon site-example #98

Closed LeSpocky closed 6 years ago

LeSpocky commented 6 years ago

Gluon contains an example for the subfolder site below docs/site-example. This merges not yet applied changes from the v2016.2.7 example to our site.conf and site.mk files.

This introduces options supported_rates and basic_rate in file site.conf which "removes 802.11b compatibility for better performance".

johannwagner commented 6 years ago

I just built the firmware with your PR. It worked fine. I also flashed it to a router, which also worked. I could connect to the router with my phone and my laptop, so I suppose, that your changes are fine.

LeSpocky commented 6 years ago

Thanks for testing. Should we merge this for v0.38? I set milestone to v0.39 in the first place to have more time for testing the supported_rates and basic_rate options. I would have proposed to make a quick release v0.39 after v0.38 with changes like this.

johannwagner commented 6 years ago

I am not sure, if people would notice, that we disable 802.11b. I think, almost every device also supports the next 802.11g standard, dunno, if there are metrics about this. Gluon should test their options, so I would assume, that the setting itself is stable.

I would merge it ASAP.

penguineer commented 6 years ago

I vote for merging in 0.39.

The current firmware is almost ready and has been tested for a while. We should roll-out before making more changes which, in turn, require re-testing.

penguineer commented 6 years ago

The changes in the site.mk are redundant (came with the last firmware version). Maybe this part of the commit can be removed?

LeSpocky commented 6 years ago

I just rebased on master.

The changes in the site.mk are redundant (came with the last firmware version). Maybe this part of the commit can be removed?

The intention of those changes (and of the whole PR) is to keep our files as close as possible to the files from site-example to simplify merging later upstream changes from the examples.