search

FriendsOfFlarum / amazon-affiliation

Add your Amazon Affiliate tag to Amazon links
MIT License
3 stars 1 forks source link

Update for beta8 #1

Closed matteocontrini closed 5 years ago

matteocontrini commented 5 years ago

Here's a PR for beta8 support. I tested the features and everything seems to work.

The only thing I don't understand is why when enabling the extension the settings modal is not shown. What I see is that the page becomes "darker", as if the modal was open but invisibile. Clicking anywhere closes the invisibile modal, and then the modal can be opened manually by clicking the "Settings" menu item.

clarkwinkelmann commented 5 years ago

Sorry I didn't notice your PR (because I had notifications disabled :see_no_evil: ), I'll try to take a look soon.

I will check with the other FriendsOfFlarum members what we want to do with this extension. Either way, it will have to switch namespace if it's updated.

Ralkage commented 5 years ago

I ended up doing this from scratch to update for Beta 9 instead, thank you for your contribution and time @matteocontrini! :)

matteocontrini commented 5 years ago

Thanks!

matteocontrini commented 5 years ago

@Ralkage is the release on Packagist for fof/amazon-affiliation correct? I installed it but I'm seeing the old name...

immagine

And when I enable it there's no settings button.

Ralkage commented 5 years ago

@matteocontrini I haven't release the updated version yet which includes my recent commits :) it will be out tomorrow as well as a new discussion on Flarum Discuss👍