Closed dsevillamartin closed 10 months ago
Haven't implemented Pusher or tests. For Pusher, probably would want another event that just updates the count of the reaction type and have front-end handle if the user's reaction has been deleted... otherwise would require many events to be fired for deleting reaction types off posts.
Changes proposed in this pull request:
Reviewers should focus on: This logic does not work for anonymous votes. It'd make sense to allow to delete an entire reaction type (I really hate the terminology being the same 😮💨), but I wasn't sure what API URL to use for that. As it stands already, it's not clear whether the endpoint is for a
post_reaction
orreaction
ID... and since/posts/{id}/reactions
returnspost_reactions
, I don't know whether the mismatch can be avoided at all.Screenshot
Confirmed
composer test
).