Flarum 1.0 - Githubissues

FriendsOfFlarum / secure-https

Changes all images using HTTP to HTTPS

https://discuss.flarum.org/d/17771

MIT License

6 stars 7 forks source link

Flarum 1.0 #15

Closed imorland closed 3 years ago

imorland commented 3 years ago

[x] Update for 1.0
[x] Tested working when Proxy images is disabled
[x] textformatter filterChain does not work :(

dsevillamartin commented 3 years ago

I tested it, and it looks like the filter chain only applies when saving posts. This isn't good because it also means posts will keep the proxy URL when the extension is disabled. We might need to use parsing and/or unparsing...

dsevillamartin commented 3 years ago

I managed to make it work using the render hook - it doesn't work during preview (post/edit) but it doesn't modify the saved XML content, which I think is the most important part. We can probably add some JS hook to change the URLs somewhere, though I don't think it's a big priority.

Let me know what you think about these commits.