FriendsOfFlarum / socialprofile

Add custom social media pages to your user profile
MIT License
13 stars 7 forks source link

Website icons not showing up #27

Closed hrvoje-hr closed 2 years ago

hrvoje-hr commented 3 years ago

Bug Report

Current Behavior External website icons are not displayed in social icons field

Steps to Reproduce Go to profile page, enter website link in the social icons field

Expected Behavior External website icon should be displayed

Screenshots https://i.ibb.co/NtG1qVj/Schermafbeelding-2021-11-02-230511.png

Environment

| flarum-flags                  | v1.1.0  |        |
| flarum-tags                   | v1.1.0  |        |
| flarum-subscriptions          | v1.1.0  |        |
| flarum-approval               | v1.1.0  |        |
| flarum-suspend                | v1.1.0  |        |
| flarum-markdown               | v1.1.0  |        |
| the-turk-nodp                 | 1.0.1   |        |
| sycho-profile-cover           | v1.3.0  |        |
| sycho-move-posts              | v0.1.5  |        |
| fof-socialprofile             | 1.1.0   |        |
| fof-reactions                 | 1.0.2   |        |
| fof-links                     | 1.0.3   |        |
| fof-gamification              | 1.2.0   |        |
| fof-formatting                | 1.0.1   |        |
| fof-follow-tags               | 1.0.2   |        |
| fof-drafts                    | 1.0.3   |        |
| fof-byobu                     | 1.0.1   |        |
| flarum-sticky                 | v1.1.0  |        |
| flarum-statistics             | v1.1.0  |        |
| flarum-nicknames              | v1.1.0  |        |
| flarum-mentions               | v1.1.1  |        |
| flarum-lock                   | v1.1.0  |        |
| flarum-lang-english           | v1.1.0  |        |
| flarum-emoji                  | v1.1.0  |        |
| clarkwinkelmann-author-change | 1.0.2   |        |
| askvortsov-rich-text          | v2.1.0  |   

Additional Context

In edit buttons menu favicons are loaded as they should, but not in the social icons field.

Also reported by other users on Disucss.

dsevillamartin commented 2 years ago

@hrvoje-hr In case this is still an issue, did you perhaps have the option disabled in settings? It was added in the v1 update

image

Xwdit commented 2 years ago

@hrvoje-hr In case this is still an issue, did you perhaps have the option disabled in settings? It was added in the v1 update

image

I have this problem too, allow external website icons already enabled

imorland commented 2 years ago

Testing this using Firefox, it seems the external icons are blocked:

image

I've not yet tried other browsers

dsevillamartin commented 2 years ago

Well, Privacy Badger is an extension. It makes sense for it to be blocked due to potential tracking, I guess. I don't think we should attempt to solve this problem, perhaps just add some error handling to the icons instead and/or default to web icon.

davwheat commented 2 years ago

This might be fixed by 32c0aebbefd00a643b53290d4438259510a18b97