FriendsOfShopware / FroshEnvironmentNotice

Work in Progress
MIT License
8 stars 1 forks source link

Composer installation lacks backend controller #3

Closed JoshuaBehrens closed 6 years ago

JoshuaBehrens commented 6 years ago

If installed via composer there are errors in the backend controller as the template is not build.

Actual behaviour

The current plugin expects the backend template to be compiled via npm befure being usable.

Expected behaviour

One can simply install by composer and the backend template gets rendered by npm automatically

OR

there is no need for npm while keeping the advantages in a reasonable amount.

Steps to reproduce

  1. Install the plugin via git or composer
  2. Do not execute npm

Checklist

dneustadt commented 6 years ago

See the extjs branch featuring a native extjs app. Since there is no need to build assets with a native app there will always be a app.js present no matter the deployment method.

JoshuaBehrens commented 6 years ago

I will look at this as soon as possible. Thanks so far for the extjs contribution I could never serve.

JoshuaBehrens commented 6 years ago

Looks good, works as expected. :+1: