search

FriendsOfTYPO3 / tea

Example extension for unit testing and best practices.
https://typo3.org/community/teams/best-practices
GNU General Public License v2.0
74 stars 23 forks source link

Switch the Docker images on GitLab from Stefan's personal images to the official Core testing images #1324

Open oliverklee opened 3 months ago

oliverklee commented 3 months ago

Goal

we want to user the official Core Testing Images instead of Stefan's personal images.

Acceptance criteria

sbuerk commented 3 months ago

FYI - runTests.sh already uses core testing images, see https://github.com/FriendsOfTYPO3/tea/blob/234251eaea35a33801ea75c37dfbb84b16def258/Build/Scripts/runTests.sh#L438-L443

Do you refer to the gitlab workflow files ?

Note: Using a dind/podman-in-podman compatible runner/multi-runner and use runTests.sh in ci directly would always use the same images as in that file and in github action also. However, there are some minor things left which needs to be done that all things are included / executable over runTests.sh (or at least checked if it works). For example the coverage stuff.

oliverklee commented 3 months ago

Do you refer to the gitlab workflow files ?

Yes, exactly. I came across your image while having the GitLab workflow files open for some other reason.