search

FriendsOfTYPO3 / tea

Example extension for unit testing and best practices.
https://typo3.org/community/teams/best-practices
GNU General Public License v2.0
74 stars 23 forks source link

[TASK] Move php sniff to build dir #1357

Open lukaszuznanski opened 1 month ago

lukaszuznanski commented 1 month ago

Part of: https://github.com/FriendsOfTYPO3/tea/issues/1186

lukaszuznanski commented 1 month ago

We also need to adapt .gitattributes and the prepare-release Composer script.

We remove whole Build dir, so only .gitattributes needs to be adapted.

oliverklee commented 1 month ago

We remove whole Build dir, so only .gitattributes needs to be adapted.

I was thinking of removing this line that removes a file that will no longer exist after this PR:

"rm phpcs.xml",

Am I missing something here?

lukaszuznanski commented 1 month ago

We remove whole Build dir, so only .gitattributes needs to be adapted.

I was thinking of removing this line that removes a file that will no longer exist after this PR:

"rm phpcs.xml",

Am I missing something here?

Yes, that's correct, that needs to be removed.