Frogging-Family / wine-tkg-git

The wine-tkg build systems, to create custom Wine and Proton builds
856 stars 155 forks source link

Can no longer specify my own tmpdir for building, defaults to /tmp #1097

Open gardotd426 opened 9 months ago

gardotd426 commented 9 months ago

I've always had my tmpdir/BUILDDIR for makepkg, linux-tkg, and anything that compiles software set to /home/matt/tmp, because I have a 24GB tmpfs ramdisk set up there. I used to be able to build wine-tkg-git either within the wine-tkg-git directory itself, or in ~/tmp, but I noticed tonight that it's building in /tmp/wine-tkg, currently while building the size is 3GB.

I know this wasn't always the case, and grepping recursively the whole repo for any reference to setting your own tmpdir is completely gone. Is there any reason this was done? What would it take to add it back, You know I'm not anything like the wizard you are, but I've submitted plenty of patches and merge requests, is it something I could handle? If so let me know what needs done and I'll do it for you to take some work off your plate.

Tk-Glitch commented 9 months ago

The makepkg path -for wine-tkg- doesn't fiddle with this and will use makepkg's settings. However, the non-makepkg path, which is also used for proton-tkg (both makepkg and regular paths) does indeed default to /tmp as of https://github.com/Frogging-Family/wine-tkg-git/commit/765763fe86e20ba4a80d177952e9240e4b42d6cf . It's set in the file because it has to be done before .cfg check, but we could add some bypass I guess.

gardotd426 commented 9 months ago

Yeah, I mean would it be too difficult to wire up something like this, where you change the following line:

mkdir -p /tmp/wine-tkg/src

to:

mkdir -p $_tmpdir/wine-tkg/src

And have _tmpdir="" in advanced-customization.cfg, and just have it set by default to /tmp?

Like

# tmdir - temporary directory used for building
_tmpdir=/tmp

Then if anyone wants to edit it, they can. I know you said it's done before .cfg check, so if it's too hard that's okay, maybe there's another way.