Feature-gate mutable field access trait methods - Githubissues

FuelLabs / fuel-vm

Fuel v2 interpreter in Rust

Other

358 stars 88 forks source link

Feature-gate mutable field access trait methods #802

Closed Dentosal closed 3 months ago

Dentosal commented 3 months ago

Closes #799

This is technically a breaking change, but anybody relying on this is doing something wrong.

Checklist

[x] Breaking changes are clearly marked as such in the PR description and changelog
[x] New behavior is reflected in tests
[ ] If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
[ ] The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

[ ] I have reviewed the code myself
[ ] I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

[ ] Rust SDK
[ ] Sway compiler
[ ] Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
[ ] Someone else?

Dentosal commented 3 months ago

Doesn't seem like a sensible thing to do, most of them seem to be actually used. I'll decide what to do about the issue later.