As Exchange Union I want to track the payment of funded issues

[timdierckxsens]

Precondition

• A project has succesfully funded an issue
• A developer has succesfully solved an issue
• A developer claims an issue

Scope

• FundRequestNotifier posts a message that an issue is succesfully claimed
• A funder or developer can click on a link to track the payment on a blockexplorer (for example : etherscan)

Postcondition

• The funds can succesfully be tracked on a block explorer

Acceptance Criteria

• Visible on GitHub Issue

"Thank you for your code contribution. The reward linked to this issue has been transferred to your account. Please track payment details .

Looking for more? Feel free to browse through all funded requests."

Attachements

Additional Question

• Does the block explorer text + link only need to be added when an issue is claimed or also when it is funded

[fundrequestbot]

This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g. fixes #515

• For more help on how to claim on issue, please visit our help section.
• Looking for more? Feel free to browse through all funded requests.

[marc0olo]

I would like to solve this :-)

When I analyzed this topic correctly all required data is already available and following changes have to be implemented:

1. extend the method createGithubCommentOnRequestClaimed in io.fundrequest.core.request.claim.handler.CreateGithubCommentOnClosedHandler
   • read the information of ClaimDto which is part of RequestClaimedEvent and contains the transaction hash that can be used to generate the link to etherscan
2. pass the transaction hash through the methods that generate the comment
3. extend the template string RESOLVED_COMMENT_TEMPLATE in io.fundrequest.platform.github.GithubCommentFactory and add a new placeholder for the transaction hash

Is this how you would like to see it implemented? What is the deadline?

[fundrequest-notifier]

Hi @marc0olo ,

Your analysis looks correct except you have to adapt the CLOSED_COMMENT_TEMPLATE string for the new placeholder (the other template is used to indicate to the user that he has the claim the reward, so the transaction does not exist yet)

So yeah, it can be implemented like that!

This was a request from ExchangeUnion, there was no real deadline but the sooner the better :)

P.S. you also will have to adapt the test GithubCommentFactoryTest

[marc0olo]

ok cool. yeah the template string was wrong, I see. will implement this as soon as possible :-)

do you plan to add a possibility to reserve an issue for a certain time period? that's currently not possible :-/

[alpa-coder]

not yet, in the future we will introduce a staking mechanism where a user can stake FND tokens on the issue that he wants to solve where we could introduce some functionalities around this.

People that are reading this see that you are working on it, so your solution will get preference for now

[fundrequestbot]

Thank you @marc0olo for your code contribution. The reward linked to this issue has been transferred to your account.

• Payment details can be tracked on Etherscan
• Looking for more? Feel free to browse through all funded requests.