search

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.99k stars 2.3k forks source link

[BUGFIX] Fix the instrumental selector being spammable #3866

Open AbnormalPoof opened 1 week ago

AbnormalPoof commented 1 week ago

Does this PR close any issues? If so, link them below.

Fixes #3562

Briefly describe the issue(s) fixed.

CapsuleOptionsMenu has its own method of handling inputs, independent of FreeplayState. This, in turn, meant that inputs were still enabled even AFTER selecting a song.

This PR adds a Boolean called busy. This pretty much acts the same as the one in FreeplayState.

This is sort of a janky solution, but you can't really do anything much on the Freeplay side since busy is enabled to prevent FreeplayState from accepting inputs while the Instrumental Selector is open (unless you like... made a new boolean to check if the instrumental selector is open or something lol).

Something to note

The arrows in the Instrumental Selector (InstrumentalSelector) can still be controlled, however, this is purely a visual thing. I tried tackling the issue before opening this PR, but I couldn't really figure out a solution without it being a mess.

Honton129 commented 1 week ago

si please i need this to be merged so bad