FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.99k stars 2.3k forks source link

Bug Report: Screenshot sticks around after exiting the menu it came from (With a suggestion to fix it) #3880

Closed sphis-Sinco closed 1 week ago

sphis-Sinco commented 1 week ago

Issue Checklist

Platform

Newgrounds (Web/HTML5)

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

I was making this issue. https://github.com/FunkinCrew/Funkin/issues/3879#issue-2673378551

And the screenshot stuck around screenshot-2024-11-19-14-00-11 screenshot-2024-11-19-13-59-52

But something I noticed is that it doesn't go away when you switch states before it is supposed to fade away.

So yeah. A recommendation to help fix it would be to have a function for clearing the screenshots when you change states.

So every time you switch to a new state it calls the function and any screenshots that exist are terminated.

(Ignore me bolding the word: terminated. The voices in my head made me do it)

Steps to Reproduce

No response

Hundrec commented 1 week ago

This has been around for a while, since https://github.com/FunkinCrew/Funkin/issues/2817

sphis-Sinco commented 1 week ago

This has been around for a while, since #2817

Then im fixing it

charlesisfeline commented 1 week ago

Then im fixing it

theres already a branch that fixes it in this repo (persistent-screenshot-preview) btw

sphis-Sinco commented 1 week ago

Then im fixing it

theres already a branch that fixes it in this repo (persistent-screenshot-preview) btw

i figured that out after i rage quit at trying to fix it

charlesisfeline commented 1 week ago

theres already a branch that fixes it in this repo (persistent-screenshot-preview) btw

i figured that out after i rage quit at trying to fix it

aight