Open tplobo opened 1 year ago
@oliverfunk, @je-cook, take a look and check whether this seems clear. I intend to add a few more tasks from the presentation I gave you guys earlier this year, just to collect all the suggestions I made at the end of the presentation in a single place.
I've rearranged the above into blocking and non-blocking sections. The blocking/non-blocking is for merge into develop.
The merge of #1250 into its feature branch is before this (at least in part) as most of these should be isolated PRs. Once we've had #1250 reviewed and any further changes undertaken we can tackle this list.
Majority now covered by #2873, only export not covered (I think)
Description of issue / requirement to address
List of tasks to be addressed in the
power_cycle
feature branch before it can be merged intodevelop
.0 - Legacy (closed/superceeded by #2873)
Enum
class for distinguishingactive
andreactive
loads and add classification attribute to power load.1 - Blocking
The tasks below are classified in terms of implementation status: (*) - started (**) - not started
coilsupply.py
verification example with EU-DEMO 2017 data into a test ( to be possibly superceeded if EU-DEMO is moved to different repository).name
anddescription
into properties for immutability~ [CANCELLED]LoadSet
for currents, voltages, etc.coilsupply.py
classes to be compatible with and use functionalities ofnet.py
(#3017).power_cycle
module, in 2 levels (net loads only, and cached full simulation) (#2549)2 - Non-Blocking
net.py
classes as a model verification.add
,mul
,truediv
...) to user-interface classes (e.g.LoadConfig
).coilsupply.py
classes based on a coil currents and voltages computed with a minimal working example of theequilibria
module.LibraryConfig
from reactor object, so that some power loads can be extracted from other modules; e.g. fusion power, TF/PF coils power, ... (to be possibly superceeded by #2512).tools.py
intodisplay
module.