search

FusionAuth / go-client

FusionAuth Go Client Library!
https://fusionauth.io/
Apache License 2.0
29 stars 32 forks source link

Please use proper module versioning tag #85

Open syntaqx opened 2 months ago

syntaqx commented 2 months ago

Currently, if you go get this package, the value returned is:

go get github.com/FusionAuth/go-client/pkg/fusionauth@latest
go: downloading github.com/FusionAuth/go-client v0.0.0-20240703195400-20df799688c3

Which matches the latest sha in main 20df799, following pseudo-versions in go modules.

https://pkg.go.dev/github.com/FusionAuth/go-client/pkg/fusionauth?tab=versions image

This would normally not be a huge deal, except that the latest version is returning this error for my application:

# github.com/FusionAuth/go-client/pkg/fusionauth
../../../go/pkg/mod/github.com/!fusion!auth/go-client@v0.0.0-20240703195400-20df799688c3/pkg/fusionauth/Domain.go:4010:2: undefined: LinkedHashMap

Which we can still:

go get github.com/FusionAuth/go-client/pkg/fusionauth@1.12.1
go: downloading github.com/FusionAuth/go-client v0.0.0-20191211173910-6751b41cf288

However, that still pins releases as a pseudo version.

The side effect of this, is it's hard to know from what's currently a work-in-progress on the main branch vs a stable release, and even harder to pin it correctly in a go.mod

To correctly use module versions, tags should be released in the format of v1.12.1, instead of the format being used 1.12.1 (missing the v prefix).

Can you please release the latest stable as a properly named tag?

https://go.dev/ref/mod

mooreds commented 2 months ago

Thanks for the suggestion. I'm going to leave this issue open so we can address it.

But your root issue of undefined: LinkedHashMap should be resolved by the commit in this PR, I believe: https://github.com/FusionAuth/go-client/issues/82