FutureMillennium / Screenshot-YouTube

Chrome extension: Take a screenshot of any YouTube video with one click.
https://chrome.google.com/webstore/detail/screenshot-youtube/gjoijpfmdhbjkkgnmahganhoinjjpohk
130 stars 29 forks source link

[Suggestion] Option to save to clipboard #4

Closed cocoaaa closed 4 years ago

cocoaaa commented 5 years ago

Hi, thank you for creating this useful extension. I'm curious if I can change the save setting to save it to the clipboard instead of downloading it to the default chrome's download location.

I often need to put the screenshot in Keynote/PPT slide and it would be really useful if I can bypass the intermediate steps of copy-pasting the downloaded image to the slides.

Thank you!

roxaloxa commented 5 years ago

Seconding this!

naturallymitchell commented 4 years ago

👍💖

FutureMillennium commented 4 years ago

Added in version 2.3.0, thanks to @roxaloxa.

cocoaaa commented 4 years ago

wow, thanks a lot!

l1bbcsg commented 4 years ago

This had the immediate effect of breaking the extension for all current users and producing a concerning warning.

Screenshot 2020-02-04 at 22 06 09

Perhaps this could have been handled better.

FutureMillennium commented 4 years ago

This should be fixed in version 2.3.2. I've removed the clipboardWrite permission, as it doesn't seem to be necessary.

roxaloxa commented 4 years ago

having to click "accept new permissions" is hardly breaking an extension, but regardless, turns out that permission was unnecessary so apologies for including that. first time messing with extension stuff. 😓

FutureMillennium commented 4 years ago

I agree with @roxaloxa, though I do wish Chrome's warning wasn't so misleading & poorly worded – you can hardly “modify” any data since you can't read anything, and what's wrong with copying to the clipboard anyway? – and that their documentation was better.

The permission is “recommended” for extensions yet you still get this awful treatment anyway.

image