FutureTense / keymaster

Home Assistant integration for managing Z-Wave enabled locks
MIT License
239 stars 44 forks source link

Remove `zwave` and `ozw` integration support #277

Closed raman325 closed 2 years ago

raman325 commented 2 years ago

Breaking change

Removes zwave and ozw support from the integration.

Proposed change

Type of change

Additional information

codecov-commenter commented 2 years ago

Codecov Report

Merging #277 (598f628) into main (05d6d37) will decrease coverage by 4.91%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   89.06%   84.14%   -4.92%     
==========================================
  Files          10       10              
  Lines        1088      801     -287     
==========================================
- Hits          969      674     -295     
- Misses        119      127       +8     
Impacted Files Coverage Δ
custom_components/keymaster/binary_sensor.py 80.24% <ø> (-2.72%) :arrow_down:
custom_components/keymaster/config_flow.py 92.47% <ø> (-3.28%) :arrow_down:
custom_components/keymaster/const.py 100.00% <ø> (ø)
custom_components/keymaster/helpers.py 76.08% <ø> (-12.12%) :arrow_down:
custom_components/keymaster/services.py 73.33% <ø> (-12.47%) :arrow_down:
custom_components/keymaster/__init__.py 89.16% <100.00%> (-1.39%) :arrow_down:
custom_components/keymaster/sensor.py 95.91% <100.00%> (ø)
custom_components/keymaster/exceptions.py 87.50% <0.00%> (-12.50%) :arrow_down:
... and 3 more
firstof9 commented 2 years ago

Tested the changes locally, and they do work.

raman325 commented 2 years ago

@firstof9 thanks for adding the tests, clearly never got a chance to do it

rcdailey commented 2 years ago

I saw this in the release notes and grew concerned:

raman325 commented 2 years ago

I saw this in the release notes and grew concerned:

  • No reference from the release notes to documentation explaining how this is a breaking change or what manual actions I need to take (unless I missed it)
  • Does this mean I can't use my Schlage Smart Deadbolt anymore (since it's zwave; provided via the zwavejs2mqtt plugin)?

Locks using zwave_js will still work. Newer version of HA don't have the zwave or ozw integrations, so we got rid of the corresponding code. It's listed as a breaking change because it was worth highlighting, but it's not really a breaking change since keymaster is now pinned to versions of HA that no longer have those integrations anyway

Monkey-Shiner commented 2 years ago

I saw this in the release notes and grew concerned:

  • No reference from the release notes to documentation explaining how this is a breaking change or what manual actions I need to take (unless I missed it)
  • Does this mean I can't use my Schlage Smart Deadbolt anymore (since it's zwave; provided via the zwavejs2mqtt plugin)?

Locks using zwave_js will still work. Newer version of HA don't have the zwave or ozw integrations, so we got rid of the corresponding code. It's listed as a breaking change because it was worth highlighting, but it's not really a breaking change since keymaster is now pinned to versions of HA that no longer have those integrations anyway

Thank you for the clarification!

lishan89uc commented 2 years ago

HAHAHAHA YOU scared the **** out of me ROFL!!!!! I thought my beautiful fe 599 will no longer work LOL!!!!