search

Fuzss / airhop

A new enchantment for jumping while in midair. Not once, not twice, but three times!
https://www.curseforge.com/minecraft/mc-mods/air-hop
Mozilla Public License 2.0
3 stars 4 forks source link

Issue with the Slow Falling effect #8

Closed sasasasara closed 2 years ago

sasasasara commented 2 years ago

Affected Versions:

  • airhop: armorplus-1.12.2-11.20.0.56
  • Minecraft: 1.16.5
  • Forge: 1.16.5-36.2.23
  • (Optional) ArmorPlus: 16.6.0

Affected Side (Client or Server):

  • [x] Client
  • [x] Server

What happens: Your hops don't reset if you have the Slow Falling effect, as if you aren't ever touching the ground after your first hops. I'm using the Ender Dragon armor from the ArmorPlus mod, which gives you permanent Slow Falling.

What you expected to happen:: The hops to reset, regardless of active status effects.

sasasasara commented 2 years ago

I'm no Java programmer, but my theory is that this line is causing the issue.

boolean isPerformingAction = player.isPassenger() || player.abilities.isFlying || player.isOnLadder();

I suspect that having Slow Falling makes player.abilities.isFlying true.

Fuzss commented 2 years ago

Thanks for the report! Fixed in v3.1.1.