Fuzss / effectdescriptions

Find out what potion effects do without checking the wiki.
https://www.curseforge.com/minecraft/mc-mods/new-effect-descriptions
Mozilla Public License 2.0
1 stars 1 forks source link

[Mod Effect Requests/Contribution]: Alex's Caves/Alex's Mobs/Deeper And Darker #4

Closed TBlazeWarriorT closed 7 months ago

TBlazeWarriorT commented 8 months ago

Suggestion (Required)

Please add effect descriptions for

Some documentation on how to add modded effect descriptions to your mod or an in-game GUI, and how to contribute with those (for other people) would be appreciated. I couldn't make Alex's Mobs descriptions work with your mod, for some reason, despite Alex's Caves effect descriptions working.

JEED effect descriptions from Alex's Mobs github repository, in case you want your mod to also display them:

Fuzss commented 7 months ago

thanks for the descriptions! I've included the ones you made yourself in the 1.20.4 port, assuming that alex's caves will update eventually. I can't add the descriptions from JEED unfortunately due to licensing issues, but writing up new descriptions for effects would be an option.

TBlazeWarriorT commented 7 months ago

thanks for the descriptions! I've included the ones you made yourself in the 1.20.4 port, assuming that alex's caves will update eventually. I can't add the descriptions from JEED unfortunately due to licensing issues, but writing up new descriptions for effects would be an option.

Thanks, that's pretty cool. I plan to stay on 1.20.1, but since I have them on my end already, I'm covered. Maybe in the future there could be a hook to get the JEED descriptions via code so there's no copyright issue? Or I can just try to ask for permission. Otherwise I can probably write new descriptions.

Fuzss commented 7 months ago

The JEED descriptions are already used when present.

RandomGuy91 commented 3 months ago

@TBlazeWarriorT Where did you find the extra descriptions for the 1.20.1 version? Or did you make them yourself? (If so would you be willing to share them/tell me how to make them?) Thanks!

TBlazeWarriorT commented 3 months ago

@TBlazeWarriorT Where did you find the extra descriptions for the 1.20.1 version? Or did you make them yourself? (If so would you be willing to share them/tell me how to make them?) Thanks!

Most of the info is already described on the issue, except how to actually make it, other than following the template (which is more or less how I did it anyways). For the original ones, I had to look at the other mods source code to know about the enchant, then find the enchantment id by trial and error, then look at this mods source code for reference, then inject it on a resource pack lang file iirc, then test it. Anything that isnt original was gotten from code

RandomGuy91 commented 3 months ago

Gosh, okay. Thanks, I’ll see how long it takes me 😂