search

FxMorin / carpet-fixes

fabric-carpet extension mod which attempts to fix as many vanilla minecraft bugs as possible. Feel free to add as many fixes as you want! Currently 220+ Fixes!
MIT License
134 stars 22 forks source link

update to support 1.20.4 #163

Closed petersv5 closed 10 months ago

petersv5 commented 10 months ago

This is an early stab at updating to 1.20.4. There are several deficiencies:

The mod does compile and work for the few fixes I have tried.

This should eventually resolve #159.

FxMorin commented 10 months ago

Will be taking a look at this today

FxMorin commented 10 months ago

carpetfixes.mixins.advanced.MinecraftServer_autosaveDelayMixin needs to be rewritten to match the changes in the game

I'll be removing it.

I do not understand what carpetfixes.mixins.reIntroduced.PlayerManager_LlamaRidingDupeMixin is trying to do with the "vmp" and "c2me" prefixes.

I'll also be removing that rule. Those prefixes are for the vmp (very many people) & c2me (Concurrent Chunk Management Engine) mods. It's a compatibility fix.

The method call intercept to com.google.commons.collect.Maps.newHashMap() fail in carpetfixes.mixins.blockFixes.PistonBlock_pushOrderMixin and I do not understand why.

Ya mixin always does this for google commons, not sure why. However it will still inject correctly.

petersv5 commented 10 months ago

The method call intercept to com.google.commons.collect.Maps.newHashMap() fail in carpetfixes.mixins.blockFixes.PistonBlock_pushOrderMixin and I do not understand why.

Ya mixin always does this for google commons, not sure why. However it will still inject correctly.

I thought I was going crazy. :-)