FxMorin / carpet-fixes

fabric-carpet extension mod which attempts to fix as many vanilla minecraft bugs as possible. Feel free to add as many fixes as you want! Currently 220+ Fixes!
MIT License
134 stars 22 forks source link

Comparator bug in Update Supression #170

Closed DeepResonanceHub closed 7 months ago

DeepResonanceHub commented 7 months ago

Description On version 1.20.1, when the compressor was triggered, the comparator remained suspended in the air when the hatch was opened, available for interaction. It was also updated as a regular comparator, allowing you to create shadow objects. However, on version 1.20.4, it crashes immediately after opening the hatch, and only the phantom block remains, which is also not updated.

To Reproduce Steps to reproduce the behavior:

  1. Go on 1.20.4
  2. Start with CARPET and CARPET FIXES
  3. Set normal update suppression settings.
  4. Reproduce my moves.

Expected behavior I expected to see that the comparator would not fall out and would remain hanging on the hatch, capable of being updated without destruction.

Screenshots image

Minecraft Version:

Additional context Sorry, I'm not very good in English.

silverfox0000 commented 7 months ago

Do you fixed it or not? If yes, what you do to fix it? I got same problem

Crystal0404 commented 7 months ago

Do you fixed it or not? If yes, what you do to fix it? I got same problem

This is in line with expectations, I think 1.20.4 should do that(At least 1.20.5 it works) 2024-04-27_16 56 05 Remove redstone block

Crystal0404 commented 7 months ago

FxMorin is very busy and may not have time to deal with this, If you need a rule to work around this change

Please try https://modrinth.com/mod/crystalcarpetaddition /cca ComparatorIgnoresStateUpdatesFromBelow true(>=1.20.5)

/cca ComparatorCanPlaceAboveAir true(1.20.4)

It only works with comparators, and I did it on purpose

If you want repeaters to do the same... I've heard that tis-carpet will introduce more powerful rules to address these issues https://modrinth.com/mod/carpet-tis-addition