Closed Jacalz closed 3 years ago
I guess this should be a draft PR for now? I'll see if I can look into the settings code.
I can't see anything wrong, can you expand on the problem you were encountering @Jacalz ?
I can't see anything wrong, can you expand on the problem you were encountering @Jacalz ?
Sure thing. The resizing of windows is entirely broken when using window decorations on the right side. I've tried to put the spacers in different places but to no avail. Having them on the left works as expected.
There is of course also the issue with windows not updating when the left/right setting change. You have to open a new window for it to show.
Ah yes I see. There is an optimisation in the code that chops the image in two so it can be resized without redrawing. If you move the chop position in appropriately it should be fixed.
See internal/x11/win/frame.
around 345:
iconAndBorderSizePix := iconSizePix + x11.BorderWidth(x11.XWin(f.client))*2
This should now be completed on feature/decorations
branch for perusal before pulling in here/opening new PR.
Closing this in favor of a new PR coming up shortly...
This is unfortunately as far as I could get on my own. There are various issues that I have been unable to solve.
The windows do not resize correctly when using right position.
Already open windows do not update when applying the setting in settings.
The correct selected values are not shown in settings on start. Seems to be an issue in the clock as well so not related to this PR, I guess.