FyshOS / fynedesk

A full desktop environment for Linux/Unix using Fyne
https://fyne.io/fynedesk/
Other
1.02k stars 47 forks source link

Half working left or right toolbar button pos #170

Closed Jacalz closed 3 years ago

Jacalz commented 3 years ago

This is unfortunately as far as I could get on my own. There are various issues that I have been unable to solve.

andydotxyz commented 3 years ago

I guess this should be a draft PR for now? I'll see if I can look into the settings code.

andydotxyz commented 3 years ago

I can't see anything wrong, can you expand on the problem you were encountering @Jacalz ?

Jacalz commented 3 years ago

I can't see anything wrong, can you expand on the problem you were encountering @Jacalz ?

Sure thing. The resizing of windows is entirely broken when using window decorations on the right side. I've tried to put the spacers in different places but to no avail. Having them on the left works as expected.

https://user-images.githubusercontent.com/25466657/109161196-0f832a80-7777-11eb-9a1a-f600eec60769.mp4

There is of course also the issue with windows not updating when the left/right setting change. You have to open a new window for it to show.

andydotxyz commented 3 years ago

Ah yes I see. There is an optimisation in the code that chops the image in two so it can be resized without redrawing. If you move the chop position in appropriately it should be fixed.

andydotxyz commented 3 years ago

See internal/x11/win/frame. around 345:

iconAndBorderSizePix := iconSizePix + x11.BorderWidth(x11.XWin(f.client))*2

andydotxyz commented 3 years ago

This should now be completed on feature/decorations branch for perusal before pulling in here/opening new PR.

Jacalz commented 3 years ago

Closing this in favor of a new PR coming up shortly...