search

G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

Change creation of Properties #813

Closed jgrewe closed 4 years ago

jgrewe commented 4 years ago

So far we set chunking to auto and hence properties reserved quite a bit of unnecessary overhead. With this PR, the default size is reduced to 8 entries for Properties that are created without or only a single value. If they are created with a vector of values, the vector size is used to define the size and the chunking of the H5 dataset. Compression has been switched on.

These changes are analogous to recent nixpy changes

codecov[bot] commented 4 years ago

Codecov Report

Merging #813 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   94.71%   94.74%   +0.03%     
==========================================
  Files         179      179              
  Lines       12540    12545       +5     
==========================================
+ Hits        11877    11886       +9     
+ Misses        663      659       -4
Impacted Files Coverage Δ
backend/hdf5/SectionHDF5.cpp 97.81% <100.00%> (+0.08%) :arrow_up:
backend/hdf5/h5x/H5Group.cpp 83.33% <0.00%> (+2.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd22ba0...6a9403f. Read the comment docs.