Closed telppa closed 1 year ago
Please use separate pull requests for separate features. It greatly facilitates my ability to accept/reject individual features, and when a request isn't quite ready to merge it makes it much easier to make last-minute changes to bring it up to standards so it can be squashed & merged.
When the profilepath given by the user does not exist, try to create it I do not want this.
Add a timeout parameter to avoid dead loops There's a good case for this feature, but in addition to being in a bulk pull request the commit that implements it also makes other random changes (#Include to #IncludeAgain). And as implemented here, it breaks backwards compatibility and so cannot be merged.
Fix example EventCallbacks.ahk Changing from using data URIs to temporary files is not necessary to make this example work with your backwards-compatibility-breaking timeout parameter. Why did you do that?
If chrome.lnk is not found, we can still get a clear error info (Chrome could not be found) here instead of a com error. I like this change, please submit it as its own pull request.
Fix that GetPageList() often reports an error. Making it auto-retry is not the way I think this problem should be approached. I would suggest instead that we make the Chrome initializer wait until its debug interfaces are available before returning.