GAA-UAM / scikit-fda

Functional Data Analysis Python package
https://fda.readthedocs.io
BSD 3-Clause "New" or "Revised" License
301 stars 54 forks source link

Change quadrature in fpca test #489

Closed Ddelval closed 1 year ago

Ddelval commented 1 year ago

After diving through the source of fda.usc, I noticed that the int.simpson2 function uses trapezoid weights for the integration.

If we use those weights to calculate the scores, the results match perfectly.

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.28% // Head: 85.28% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (4248f5f) compared to base (e22beeb). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #489 +/- ## ======================================== Coverage 85.28% 85.28% ======================================== Files 137 137 Lines 11040 11044 +4 ======================================== + Hits 9415 9419 +4 Misses 1625 1625 ``` | [Impacted Files](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM) | Coverage Δ | | |---|---|---| | [skfda/tests/test\_fpca.py](https://codecov.io/gh/GAA-UAM/scikit-fda/pull/489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM#diff-c2tmZGEvdGVzdHMvdGVzdF9mcGNhLnB5) | `99.32% <100.00%> (+0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GAA-UAM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.