more input sanitation required

GCCempt / GCC_OpenSong_bot

We were lazy and didn't want to do things by hand so instead we spent hundreds of manhours automating it. classic.

http://gccpraise.com/

2 stars 0 forks source link

more input sanitation required #104

Closed dan4222 closed 3 years ago

dan4222 commented 3 years ago

Placing a dash at the end of a Song line in the worship schedule causes the song validation to fail spectacularly.

Example

Songs

The Lord is My Salvation - V1 V2 C V3 V4 C V5 C B1 B2 -

AllDayJon commented 3 years ago

@dan4222 I cannot seem to reproduce this - do you know which commit main was on when this happened? Maybe we can tag releases so we can check code from that point in the repo after :)

dan4222 commented 3 years ago

unable to recreate issue by postings by any of the Dev team. Issue seems persistent whenever a worship schedule is posted by a user in Prod.

On hold till issue is seen after the 2.00 release.

dan4222 commented 3 years ago

Issue is still occurring after v2.00