search

GCX-HCI / ThirtyInch

a MVP library for Android favoring a stateful Presenter
Apache License 2.0
1.03k stars 101 forks source link

Use AndroidX #197

Closed StefMa closed 4 years ago

StefMa commented 4 years ago

Same as #166 but with a cleaner history 🙃.

Sry I was unable to do a rebase /w a force push at #166 and therefore I created a patch file, applied it and committed it by myself. But I have you some credits in the commit message @rehlma ;)

I also removed all the "clutter" from #166 were we have done a lot more than "just updating to AndroidX"... I will create new PRs with the stuff we did there 👍

rehlma commented 4 years ago

Ah okay I see. IMHO it was part of AndroidX. But it's fine : thumbsup:

Stefan M. notifications@github.com schrieb am Fr., 9. Aug. 2019, 14:41:

@StefMa commented on this pull request.

In thirtyinch/build.gradle https://github.com/grandcentrix/ThirtyInch/pull/197#discussion_r312460392 :

  • testCompileOnly "com.android.support:support-annotations:$supportLibraryVersion"

  • testCompileOnly "androidx.annotation:annotation:$androidXAnnotationVersion"

Yep. But I just wanted to "migrate to androidx" and not "update all the things" 🙃

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/grandcentrix/ThirtyInch/pull/197?email_source=notifications&email_token=AEAMGFAGDPPEY6VTAPYO4ZLQDVQYBA5CNFSM4IKS5A62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBDWHSQ#discussion_r312460392, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAMGFHLMJCAOJ5DBEG53VTQDVQYBANCNFSM4IKS5A6Q .