GDD-Nantes / FedShop

Code for FedShop: The Federated Shop Benchmark
GNU General Public License v3.0
8 stars 1 forks source link

CostFed times out randomly #48

Open mhoangvslev opened 1 year ago

mhoangvslev commented 1 year ago
mhoangvslev commented 1 year ago
mhoangvslev commented 1 year ago
01:03:07.904 [main] INFO  com.fluidops.fedx.FedX - Shutting down federation and all underlying repositories ...
org.eclipse.rdf4j.query.QueryEvaluationException: java.lang.InterruptedException: cancelled
        at com.fluidops.fedx.evaluation.iterator.QueueIterator.checkException(QueueIterator.java:111)
        at com.fluidops.fedx.evaluation.iterator.QueueIterator.getNextElement(QueueIterator.java:41)
        at com.fluidops.fedx.evaluation.iterator.RestartableLookAheadIteration.lookAhead(RestartableLookAheadIteration.java:50)
        at com.fluidops.fedx.evaluation.iterator.RestartableLookAheadIteration.hasNext(RestartableLookAheadIteration.java:21)
        at com.fluidops.fedx.evaluation.union.UnionExecutorBase.getNextElement(UnionExecutorBase.java:111)
        at org.eclipse.rdf4j.common.iteration.LookAheadIteration.lookAhead(LookAheadIteration.java:90)
        at org.eclipse.rdf4j.common.iteration.LookAheadIteration.hasNext(LookAheadIteration.java:52)
        at com.fluidops.fedx.evaluation.iterator.QueueIteration.getNextElement(QueueIteration.java:44)
hartig commented 1 year ago

I think it is not our job to fix bugs in CostFed, not even to identify the cause of them.

I suggest if less than half of the executions of a query time out, you ignore the timed-out ones and consider only the non-timeout measurements. Otherwise, you count the query as timed out or as failed.

Additionally, if you want to be nice, you post a bug report at the CostFed repo, but I wouldn't overdo it in terms of putting a lot of time into it.