GDSC-SIT-2024 / HacktoberFest-Session24

3 stars 39 forks source link

Update index.html #7

Open Hardik25-iso opened 1 week ago

Hardik25-iso commented 1 week ago

Broken HTML Structure:

In the back section of the card (

), there is an incomplete
tag. Missing some closing tags and misaligned indentation.

Accessibility:

The form fields lack aria-label or aria-describedby attributes to support screen readers. Placeholders like empty

Incorrect use of type="num" for credit card numbers. It should be type="text" with input masking/validation since card numbers are not truly numeric data.

Missing Input Validation and Formatting:

No real-time validation or formatting for credit card number, expiration date, or CCV. Fields like card numbers should include spaces or dashes for readability.

Static Expiration Years:

Expiration years are hardcoded (2016–2025), which will make the form outdated over time.

Autocomplete Attribute:

The form has autocomplete="off", which disables helpful features like autofill for users.

Missing Required Fields:

No required attributes on input fields to enforce necessary input.

Security Icon Misleading:

A lock icon () is used, but no actual security measures (such as HTTPS or encryption) are in place. The icon can give a false sense of security.

No dynamic Card Type Detection:

The card type is hardcoded to Visa. There’s no mechanism for dynamically changing the card logo based on the card number.

Soyvor commented 1 week ago

Ok solve the issue and move forward with them