search

GDSC-UPES / GDSC-UPES-Website

MIT License
16 stars 26 forks source link

feat: add a responsive event detail hero page #34

Closed lokesh-wagh closed 11 months ago

lokesh-wagh commented 1 year ago

fixes #9

netlify[bot] commented 1 year ago

Deploy Preview for upes-gdsc ready!

Name Link
Latest commit 7949fd5408f752c677bad4bd4b75b3984c623b97
Latest deploy log https://app.netlify.com/sites/upes-gdsc/deploys/652255de2139c6000904d740
Deploy Preview https://deploy-preview-34--upes-gdsc.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 85
Accessibility: 84
Best Practices: 100
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

lokesh-wagh commented 1 year ago

image build has been successful locally

don't know why it is causing issue's

rohin079 commented 1 year ago

@lokesh-wagh Kindly look at the build preview logs to find out why the build is failing, correct it and then try to raise another commit until all checks are passed

lokesh-wagh commented 1 year ago

hey the build issue's are resolved can you merge it now

rohin079 commented 1 year ago

@lokesh-wagh the css of the homepage has been changed due to which its UI is looking different :

image

kindly update that to make it look like this again:

image

lokesh-wagh commented 1 year ago

hey !!

i have fixed the UI issue

rohin079 commented 1 year ago

@lokesh-wagh The dark theme button is still left, other than that, great work! Commit that and i'll close the issue as completed

lokesh-wagh commented 1 year ago

Can you elaborate what i am supposed to do with the dark themed button

rohin079 commented 1 year ago

Can you elaborate what i am supposed to do with the dark themed button

The alignment of the dark theme button has been changed ( refer to the ss) and its animation has stopped working w your commit, fix that to how it were before you added your changes: https://upes-gdsc.netlify.app/ Look at the dark theme button on this page at top right

rohin079 commented 12 months ago

@lokesh-wagh Any updates?

lokesh-wagh commented 12 months ago

Hey!!

Can i get some more time to fix this minor issue Actually i have a techfest to compete in at my college

rohin079 commented 12 months ago

@lokesh-wagh Sure, no issues :)

rohin079 commented 11 months ago

@lokesh-wagh Any updates?

lokesh-wagh commented 11 months ago

Hey !! I am closing this PR since i need to prepare for ICPC sry