GENI-NSF / geni-ch

GENI clearinghouse services
Other
3 stars 6 forks source link

Should sliver_info reject all bad sliver URNs? #357

Open ahelsing opened 9 years ago

ahelsing commented 9 years ago

Should the sliver_info table reject sliver URNs that are not well formed?

Currently, the AuthZ code rejects things that are not valid urns, as in:

05/20/2015 15:27:30:ERROR   :amsoil:[sav1] [ARGUMENT] ARGUMENT_ERROR (Ill-formed argument of type URN field SLIVER_INFO_URN: urn:publicid:IDN+exogeni.net:ucdvmsite+sliver+90b5b32b-5955-48f8-8209-53238519f1f3:Client 3)

Note that the sliver name includes a space (between Client and 3). It also includes a colon (:). According to the spec neither is allowed.

How bad would it be if we accepted non compliant sliver URNs?

nbastin commented 7 years ago

It should continue to reject non-compliant URNs. Supporting them just means that other tools don't have any leverage to get them fixed, and have to build the same non-complaint support in (usually "discovering" these issues at different times). We should all just agree that this URN is broken.