Review, improve RSpec parsing logic

[ahelsing]

We should review and improve the logic for parsing RSpecs uploaded to the portal

• Ensure it detects bound and stitchable RSpecs similarly to stitcher
• Tag GRE RSpecs (which stitcher can also handle)
• Tag Multi-AM (which stitcher should be taught to handle)
• Detect Partially bound

• Consider extracting the list of AMs used by the RSpec

  Imported from trac ticket #1099, created by ahelsing on 07-18-2014 at 15:33, last modified: 03-31-2015 at 10:20

[ahelsing]

Current logic says: If any node is bound, RSpec is bound. That should mean partially bound, and only if all nodes are bound is the RSpec fully bound.

Also, current logic says it is stitching if it has a link with >2 AMs. Stitcher on the other hand requires also (a) there isn't a shared_vlan extension, and (b) there isn't an explicit different link type marked on the link.

Note that we want stitcher to be able to handle links with a shared vlan tag.

Also note that stitcher can handle an RSpec that uses a GRE link (2 interfaces at different AMs with link type of gre or egre).

Trac comment by ahelsing on 07-31-2014 at 13:27

[ahelsing]

Next version of stitcher handles any bound multi-AM RSpec. So the stitching distinction is less important. We want to detect fully bound vs partially bound (an error - not handled) vs unbound, and single AM vs multi AM

If it is bound, ideally we will show the user what it is bound to - at least if it is a single AM. If it is unbound, the normal Add Resources page should let you send it to that AM. If it is partially bound, we should

• refuse to let you upload it, OR
• allow it to be stored in the DB, but refuse to let it be submitted to stitcher as is (you have to bind the unbound stuff using Jacks or whatever) (labeling it as partially bound)

Trac comment by ahelsing on 09-08-2014 at 12:39

[ahelsing]

New logic says it is bound if any are bound, and adds logic to add a partially_bound attribute. This attribute is not yet stored in the database.

Trac comment by ahelsing on 09-30-2014 at 14:23