search

GENL / matice

Use your Laravel translations in JavaScript.
MIT License
99 stars 15 forks source link

Exposing paths #15

Closed RomkaLTU closed 3 years ago

RomkaLTU commented 3 years ago

Expected behavior

Remove HTML comments from production build at least.

Current behavior

Comments injected 

Matice Laravel Translations generated
Used cached translations at: /home/forge/xxx/resources/assets/js/matice_translations.js

I think it's giving everyone additional unesesery information and should be removed.

GENL commented 3 years ago

Noted. It will be removed,

GENL commented 3 years ago

Fixed. Will be merged in the upcoming release.

mgralikowski commented 2 years ago

The problem still exists. The path is exposed for the world. Generally, what it the purpose of this comments? Imo those are unnecessary bytes.

GENL commented 2 years ago

Do you have the latest version? The comment has been removed,

mgralikowski commented 2 years ago

Yes, I tried dev-master as well.

Localhost: image and it is ok.

But on prod I see sth like this: image

GENL commented 2 years ago

OMG! Let me remove it now,

GENL commented 2 years ago

Please upgrade to v1.1.7.