search

GEOS-ESM / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
0 stars 2 forks source link

Update fv_grid_tools.F90 #88

Closed tclune closed 11 months ago

tclune commented 11 months ago

When introducing non-global mechanism for computing coordinates, a copy-paste mistake broke the Schmidt transform. Does not affect legacy coordinate algorithm.

Basically the loop over tiles should just be a single iteration for the local tile. Obvious in hindsight.

github-actions[bot] commented 11 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bug

github-actions[bot] commented 11 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bug

mathomp4 commented 11 months ago

@tclune Is this zero-diff (in that it only affects the local-transform path)?

tclune commented 11 months ago

Yes - zero diff for "legacy" mode. And zero diff for new when not using stretch.