Closed thom4parisot closed 5 years ago
Thanks, let me do some tests from this version before merging.
Sure 👍 here is the link to the live preview.
Here is the current proposal (👁 live preview)
For the hazard icons: could you include a row of icons, with the # datasets directly below? I think would look quite tidy. Would be useful I think to include exposure and base data as an icon too.
I don't have access to this information. At best, I can list the "perils" (by adding an extra API call), but not the figures.
Otherwise I have to go through all the datasets but we hit #280 again. If the scores are removed, maybe it would speed up this API route and make it useable for this purpose on the homepage.
It looks very nice. If we just need this quickly updated, then the only change I have is: "185 datasets in 21 countries to date." (Tested "and counting" with a non-native English speaking colleague and Stu was right that it is not a familiar term).
If we have more time, another change I'd make is to remove the grey boxes behind the "Tracking..." and "Discover..." lines. It looks unfinished or like it's been highlighted by your cursor.
Perhaps the '57 could be improved' could be more specific in its wording.
E.g. '57 are partially open'. If that can be considered technically correct/possible
'could be improved' doesn't say anything to me about improving openness,and could be taken to mean they need to be improved in terms of data quality.
Similar comment for 'could be opened'. There may be reasons a dataset is not open, and that may not change so the dataset is not possible to open in the near or far future. Consider instead 'N datasets are not open' (or 'are closed', given that term is used above on the page)
I have taken in account (all of) your feedbacks 👍
LIke it thanks
On Fri, Mar 1, 2019 at 11:05 AM Thomas Parisot notifications@github.com wrote:
I have taken in account (all of) your feedbacks 👍
[image: image] https://user-images.githubusercontent.com/138627/53634318-32c37f80-3c1a-11e9-85dc-be674440f469.png
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/GFDRR/open-risk-data-dashboard/pull/458#issuecomment-468629570, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRKx_h4zCK6WSFwR8AJaX9yHTuN3tCpks5vSQl1gaJpZM4a_C34 .
Could we also have the missing ones and a call for action? Something like still look for X datasets, help us contribute ! So that we incentivize people to contribute ?
On Fri, Mar 1, 2019 at 12:34 PM Thomas Parisot notifications@github.com wrote:
Merged #458 https://github.com/GFDRR/open-risk-data-dashboard/pull/458 into master.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GFDRR/open-risk-data-dashboard/pull/458#event-2173775788, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_PndSnNaxmsZlYcv_t8_e1xZFrtchUks5vSRBEgaJpZM4a_C34 .
@nastasi-oq the
api/stats
is no longer in use.fix #431