Incorrect Dutch translations.

StonehengeCreations commented 3 days ago

Is there an existing issue for this?

[X] I have searched the existing issues

Problem description

Several strings have translated incorrectly:

"Turn" has been translated as "Keer om", which means "Turn around". It should be "Sla {turn_maneuver}af".
"Keep" has also been translated as "Keer om, resulting into people thinking they need to make a U-turn instead of continuing in the same direction on either the left or right side. It should be "Houd {turn_maneuver} aan".
"Onto" has been translated as "richting", which means "towards" or "in the direction of". It should be "naar".

Also, in Dutch there is difference in "rechts/links" and "rechtsaf/linksaf" (right/left) when providing navigation instructions. The "af" postfix is only used when changing directions/making a turn. This can be easily solved by putting the postfix immediately after the {turn_maneuver} - without a blank space in between.

Proposed solution

"directions": {
    "north": "noordelijke",
    "northeast": "noordoostelijke",
    "east": "oostelijke",
    "southeast": "zuidoostelijke",
    "south": "zuidelijke",
    "southwest": "zuidwestelijke",
    "west": "westelijke",
    "northwest": "noordwestelijke"
},

"arrive": {
    "default": {
        "default": "Aankomst op uw bestemming",
        "name": "Aankomst op {way_name}"
    },
    "left": {
        "default": "Uw bestemming bevindt zich aan de linkerkant",
        "name": "Aankomst op {way_name}. Uw bestemming bevindt zich aan de linkerkant"
    },
    "right": {
        "default": "Uw bestemming bevindt zich aan de rechterkant",
        "name": "Aankomst op {way_name}. Uw bestemming bevindt zich aan de rechterkant"
    },
    "straight": {
        "default": "Uw bestemming bevindt zich recht vooruit",
        "name": "Aankomst op {way_name}. Uw bestemming bevindt zich recht vooruit"
    }
},
"depart": {
    "default": {
        "default": "Vertrek in {direction} richting",
        "name": "Vertrek in {direction} richting op {way_name}"
    }
},
"roundabout": {
    "default": {
        "exit": {
            "default": "Neem op de rotonde de {exit_number} afslag",
            "name": "Neem op de rotonde de {exit_number} afslag naar {way_name}"
        },
        "default": {
            "default": "Ga de rotonde op",
            "name": "Neem op de rotonde de afslag naar {way_name}"
        }
    }
},
"turn": {
    "default": {
        "default": "Sla {turn_maneuver}af",
        "name": "Sla {turn_maneuver}af naar {way_name}"
    }
},
"continue": {
    "default": {
        "default": "Blijf {turn_maneuver} gaan",
        "name": "Blijf {turn_maneuver} gaan richting {way_name}"
    },
    "uturn": {
        "default": "Maak een U-bocht",
        "name": "Maak een U-bocht naar {way_name}"
    }
},
"keep": {
    "default": {
        "default": "Houd {turn_maneuver} aan",
        "name": "Houd {turn_maneuver} aan naar {way_name}"
    }
},
"pt": {
    "start": {
        "default": "Stap {name} in",
        "headsign": "Stap {name} in richting {headsign}"
    },
    "transfer": {
        "default": "Stap over naar {name}",
        "headsign": "Stap over naar {name} richting {headsign}"
    },
    "end": "Stap uit bij {name}"
}

Additional context

No response

Forum Topic Link

No response

koebi commented 3 days ago

Hey,

thank you so much for taking the time to check and correct the dutch translation! This is great :))

I have put your changes into a pull request - would you mind looking over that and seeing whether I missed something or messed anything up?

Best regards

StonehengeCreations commented 2 days ago

Very glad to help out.

I am not quite sure about the "continue" translations, because it is not really clear to me on how those will be used. if you could provide me with an English example, that would be great.

koebi commented 2 days ago

This is mainly used to tell people to continue driving straight, e.g. when lanes are merging/splitting. Something like Continue straight onto A52 might come up.

GIScience / openrouteservice