search

GJDuck / e9patch

A powerful static binary rewriting tool
GNU General Public License v3.0
986 stars 67 forks source link

add hopper in projects #70

Closed spinpx closed 1 year ago

spinpx commented 1 year ago

Hi GJDuck,

We have used E9patch for instrumentation in Hopper's implementation. Thank you for your great work in providing E9patch. Would you consider adding Hopper to the project list?

Thanks.

GJDuck commented 1 year ago

Thanks for the link, I am happy to add it to the README.

GJDuck commented 1 year ago

There is an e9patch.diff file that seems to be a fix for #56. Can it be cleaned up and merged, or was there some problem with it? I cannot recall.

spinpx commented 1 year ago

There is an e9patch.diff file that seems to be a fix for #56. Can it be cleaned up and merged, or was there some problem with it? I cannot recall.

It is a patch that works in our testing in windows some times ago. However, I ignore it since I always test the tool in Linux. I will ask @AiDaiP for checking it.

AiDaiP commented 1 year ago

Hi GJDuck, Hopper needs to use custom initialization functions in Windows PE programs, so I made the code changes in #56 . I did some testing on my Windows (19045.3570) using the latest version of e9patch and it worked. This solution may not be general so I can't guarantee it will always be correct.

In addition, e9patch.diff in hopper has one more line of code changes than the one in #56 :

- else if (e9wcscasecmp(name->Buffer, L"user32.dll") == 0)
+ else if (e9wcscasecmp(name->Buffer, L"msvcrt.dll") == 0)

I changed this line because hopper need to call some functions in msvcrt.dll in init(). This is an inelegant but simple solution. It's not related to support Windows PE custom initialization functions.