Few enhancements

[Prometee]

Hi @arthurels69 !

I'm reading the code of your plugin to see if I can use it for my own eShops and I see some improvements to do, here is a list of tasks which can be useful:

• [ ] [AdminLogin] remove the override of the login template and use sylius_ui block sylius.admin.login.form.content (this also lead the way to Sylius 2.0 sylius_twig_hooks).
• [ ] composer.json remove "symfony/dependency-injection": "^6.0", and "symfony/webpack-encore-bundle": "^1.15" requirements they are already added by sylius/sylius depending on the Symfony version devs will use.
• [ ] config/services.yaml all your bundle/plugin services must be loaded by your plugin configuration class src/DependencyInjection/GlEventsSyliusAdminSamlExtension.
• [ ] config/services.yaml must not load app configs (ie: framework and twig one).
• [ ] config/config.yaml can be the file importing the app specific configs (ie: framework and twig one).
• [ ] config/routing.yaml replace /admin prefix by the Sylius parameter %sylius_admin.path_name%.
• [ ] Add some tests with a SAML SSO/SLO server mock to test the integration.

[arthurels69]

Thanks for your feedback @Prometee , I'll be looking at them soon (probably next week) !