search

GMLC-TDC / HELICS

Hierarchical Engine for Large-scale Infrastructure Co-Simulation (HELICS)
https://docs.helics.org/en/latest/
BSD 3-Clause "New" or "Revised" License
126 stars 40 forks source link

add mechanics for retrieving filter properties. #2693

Closed phlptp closed 1 week ago

phlptp commented 2 weeks ago

Summary

If merged this pull request will add mechanics for getting filter properties

Proposed changes

phlptp commented 2 weeks ago

will add the C version of this soon to this PR

phlptp commented 2 weeks ago

Fixes #2669

trevorhardy commented 2 weeks ago

@phlptp are you wanting a review on this?

phlptp commented 2 weeks ago

@phlptp are you wanting a review on this?

Yes, Mainly to make sure it meets your needs regarding #2669

trevorhardy commented 2 weeks ago

@josephmckinsey, can you get the C-based additions @phlptp just added into PyHELICS for testing? I don't know if we want to use the libclang script or do it manually. Maybe @nightlark has an idea on the best way to do this?

nightlark commented 2 weeks ago

For pyhelics changes: use https://github.com/GMLC-TDC/cheader2json#usage to dump ast.json files for the previous helics release (using the helics.h backup header file) and for the new development version of helics (using the new helics.h backup header file), then use it to do a diff of the ast.json files to get the changes that need to be made to pyhelics.

trevorhardy commented 2 weeks ago

For pyhelics changes: use https://github.com/GMLC-TDC/cheader2json#usage to dump ast.json files for the previous helics release (using the helics.h backup header file)...

Any update on getting these changes into PyHELICS for testing?

nightlark commented 1 week ago

For pyhelics changes: use https://github.com/GMLC-TDC/cheader2json#usage to dump ast.json files for the previous helics release (using the helics.h backup header file)...

Any update on getting these changes into PyHELICS for testing?

I don't think anyone has been working on this.