Migrate from setup.py to scikit-build-core and cibuildwheel

nightlark commented 7 months ago

[ ] Move configuration from setup.py to pyproject.toml
[ ] Combine ci/cd workflows so that contents of wheel that gets built will be tested
[ ] ~Convert NPM code in setup.py to CMakeLists.txt~ Split cli extras files out into their own thing
[x] ~Post issue/discussion in scikit-build-core about running "python scripts" as part of build steps~ (Recommendation was just port the npm stuff to CMakeLists.txt)
[ ] Switch from setup.py script to scikit-build-core (essentially moving to a CMakeLists.txt file)
[ ] Use pypa/cibuildwheel for building wheels
[ ] Use setuptools_scm for versioning
[ ] Remove assorted Python 2 backwards compatibility hacks as they are encountered

nightlark commented 5 months ago

https://github.com/GMLC-TDC/helics-packaging/tree/main/helics_apps-pip can be used as an example of what the conversion to scikit-build-core would look like, minus the NPM stuff for building the HELICS CLI.

trevorhardy commented 5 months ago

Making this conversion would make it easy to support HELICS on Docker images on ARM Macs.

nightlark commented 4 months ago

Some additional motivation for migrating: right now we run setup.py directly to build wheels — apparently this form of running setuptools has been deprecated for years and won’t work anymore in Python 3.12: https://gregoryszorc.com/blog/2023/10/30/my-user-experience-porting-off-setup.py/

nightlark commented 3 months ago

Some initial work on a few of the changes required for this is in the branch: https://github.com/GMLC-TDC/pyhelics/tree/scikit-build-core-migration

GMLC-TDC / pyhelics