Investigate why we need 3 variables to handle the VPCS startup_script

[grossmj]

https://github.com/GNS3/gns3-gui/blob/master/gns3/modules/vpcs/vpcs_device.py#L50

We have script_file, startup_script and startup_script_path ;) We should at least get rid of one.

[boenrobot]

On a quick inspection:

"script_file" is the file name, but it's not checked whether it exists or not, until it's time to actually read it. "startup_script" is the actual contents of the file, once read (None beforehand or if the file doesn't exist), and ready to be applied if necessary. "startup_script_path" I'm guessing was meant to hold the path to the file, but it's ultimately unused. Instead, "script_file" contains the full path and file name (or at least, it is assumed to). So that's the one that can be safely removed. I also checked - it's not used anywhere else in the whole gns3-gui project.

[julien-duponchelle]

For me:

• script_file: the path of the local script send to the server
• startup_script: the actual contents of the file from the local machine or the remote (exist in API)
• startup_script_path: the path of the script on the remote server (exist in API)

[julien-duponchelle]

But you are right we don't need that in init

[julien-duponchelle]

Thanks for the help @boenrobot