GNS3 / gns3-gui

GNS3 Graphical Network Simulator
http://www.gns3.com
GNU General Public License v3.0
2.19k stars 437 forks source link

The text edit dialogue keeps the applied changes even after canceling the change. #3642

Open sammy3110 opened 1 month ago

sammy3110 commented 1 month ago

Bug Description While editing a text on the plane (Changing Font, Color etc.), the changes are reflected after clicking the apply button and are still retained if the CANCEL button is clicked.

GNS3 version and operating system

Steps To Reproduce

  1. Select the 'Add a note' from the toolbar and write something on the plane.
  2. Right click on the note and select 'Text Edit'.
  3. Click on 'Select Font'.
  4. Make some changes (Font, Font Style, or Size).
  5. Click 'OK'.
  6. Click 'Apply' - THE CHANGES TAKE AFFECT.
  7. Click 'Cancel' - THE APPLIED CHANGES ARE STILL RETAINED.
grossmj commented 1 month ago

Thanks for opening an issue.

I believe this is the correct behavior. Once you click apply or click OK, the changes are applied on the item. The cancel button is just there to not apply any change and close the text editor dialog. Maybe we should add a reset button instead?