search

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.
Apache License 2.0
12 stars 28 forks source link

Update to ORM 2.9 #526

Closed gregcorbett closed 2 months ago

gregcorbett commented 2 months ago

ORM 2.9 seems to be as high as we can go now without starting to hit errors that at first glance seem to be because of our version of PHPUnit.

Exception: Serialization of 'Closure' is not allowed

NB: A workable set of packages under ORM 2.10 and 2.11 was once achievable with our version of PHPUnit in https://github.com/GOCDB/gocdb/pull/455, but I guess the ecosystem has move on since then - using the commits in https://github.com/GOCDB/gocdb/pull/455 would result in some packages being downgraded from the current state of dev.

gregcorbett commented 2 months ago

See https://github.com/GOCDB/gocdb/issues/527 for going to ORM 2.10

gregcorbett commented 2 months ago

You planning to squash this? Or at least the individual ORM updates?

I was going to leave them as is, that way if we need to roll back versions of ORM we have options other than back to 2.6

What's the symfony/cache about?

Hmm good point... goes digging ah-hah! It was discussed https://github.com/GOCDB/gocdb/pull/344#discussion_r869305680, but the resultant commit message made it's way to the ORM 2.10 commit.

I'll update the commit message, and fix the indentation, but basically this 😋: https://github.com/doctrine/orm/blob/2.9.x/UPGRADE.md#minor-bc-break-setup-tool-needs-cache-implementation

Does the composer.lock actually need reviewing, or can we trust in the auto generation?

I am happy to trust the auto generation 😆

gregcorbett commented 2 months ago

and fix the indentation

ah it's tabs and space 😋