search

GPMDP / gmusic-mini-player.js

Mini player JS transformer for Google Play Music
The Unlicense
18 stars 8 forks source link

Feature Request: Thumbs Being Visible #4

Open livejamie opened 8 years ago

livejamie commented 8 years ago

I love everything about GPMDP but one of the larger annoyances is a lack of thumbs up/thumbs down in the miniplayer.

Google moves the shuffle and repeat icons outside of the bar in their version.

For reference

GPMDP: image

Google's Official Chrome App: image

GPMDP does show thumbs when listening to the radio.

We discussed some options here to toggle this view by default potentially.

bpclarke commented 8 years ago

I've just discovered GPMDP and love the idea of having a separate program for GPM and the design but use the thumbs up/ thumbs down feature in the mini player way too much to use the program (have a lot of music I'm gradually sifting through). Would love it if this feature was implemented!

In my opinion the the best way of doing this would be to replace repeat / shuffle buttons with thumbs down / thumbs up buttons in the mini player. I very rarely use them and if I do it's once before I start playing music. It appears that this has already been done for when a radio station is being played although I don't have a subscription so can't check.

Obviously not everyone wants this feature so I guess the best way to implement this would be an option to choose shuffle / repeat or thumbs up / thumbs down in this menu: image

I have very little programming experience (have only used MATLAB on my engineering university course) but will look into it over the summer if nothing's been done by then! I've been meaning to teach myself to code anyway :) Might need a reminder though, feel free to send me one in June.

varzaman commented 8 years ago

So I started working on this, I should have something soon. Having the thumbs show up was non trivial, just some css changes. I'm working on making showing thumbs a toggle in the settings menu.

bpclarke commented 8 years ago

Awesome, made any progress since your post?

varzaman commented 8 years ago

Sorry, got busy and forgot about this.

Before I forgot though, I did somewhat implement it. The issue I have now is it doesn't dynamically change. The application needs to be restarted to have the thumbs and shuffle/repeat buttons switched.

Once I figure that out I'll request a pull request.

bpclarke commented 8 years ago

That's great! Don't you have to restart the application to change some other settings anyway? I'd be pretty happy with that implementation. Just put "(requires application restart)" after the checkbox and description?

varzaman commented 8 years ago

Yea for some things it does require restart, I guess I could do that indeed.

Let me just clean up the code, and merge in the latest changes.

bpclarke commented 8 years ago

Nice one!

MarshallOfSound commented 8 years ago

@bpclarke @Lettuceman44 Requiring a user restart is only on ONE setting and that is a core OS level API limitation. A user should not have to restart the player to shows some thumbs 😢

I've left a comment explaining how to do this without restarting

https://github.com/GPMDP/gmusic-mini-player.js/pull/8#issuecomment-227337150

varzaman commented 8 years ago

Understood, will get that changed.

varzaman commented 8 years ago

Just as a quick update as I've been busy, I have it so it switches from the shuffle/repeat to thumbs dynamically without restarting, that wasn't hard at all, just copy paste :P. It doesn't work vice versa though, and I haven't figured it out yet.

Unfortunately for me, I haven't had any internet this week, waiting for that to get fixed as well.