GPUEngineering / PDESolvers

GPU-accelerated solution of PDEs
1 stars 2 forks source link

1D Heat Diffusion Equation: Graph Simulation pyScripts #2

Closed debdal6 closed 2 weeks ago

debdal6 commented 1 month ago

Main changes

Implementation of explicit (forward-in-time) and Crank-Nicolson methods for the 1D heat equation.

Associated issues

Additional details

image

image

Advisory Needed:

alphaville commented 3 weeks ago

@debdal6 can you please ping @chemardes and me when you update this so we can review this and merge it?

debdal6 commented 3 weeks ago

@alphaville Will be very late in the night before I push my code today, but I will get it done so you can review it tomorrow and get it merged

debdal6 commented 3 weeks ago

@alphaville so turns out the bug with my plot had to do with 2 () when calculating the lambdaConstant in code. Its fixed now and the assert code was already added by us during the wednesday meeting, do you want me to add a further error message in the assert? Please advise.

Also I will put my code in the playgrounds folder in a seperate PR to avoid merge conflicts since chelsea already created the folder in her PR

debdal6 commented 3 weeks ago

@chemardes could you review it when you have some time and comment how readable the code is?

debdal6 commented 2 weeks ago

See a couple of comments from my side

@alphaville I have marked the commented code comment thread as resolved and gotten back to you on the others