Closed LJZ458 closed 3 months ago
VinzenzBildstein
commented
3 months ago That seems like a version mismatch between GRSISort and GRSIData. TDetectorHit::Wavesize() was added two weeks ago in PR #1444. This means you need to use the newest version of GRSISort. Which one do you have (apart from 4.0.0.5, which doesn't say much), meaning which commit are you on?
LJZ458
commented
3 months ago I was trying to compile with an old GRSIData version, looks like that did not work.
I have switched to the newest version of GRSISort and GRSIData, they are working now thank you! My previous GRSISort was version 4.0.0.3 i forgot the GRSIData version and currently: GRSISort version 4.0.0.5, GRSIData version 0.1.1.2
Root version = 6.30/04 GRSISort Version = 4.0.05 UBUNTU = 22.04.4
An error after make, wavesize in TZeroDegreeHit not defined.
cmake -S GRSISort-4.0.0.5/ -B GRSISort-build -DROOT_CXX_VERSION=17 -DCMAKE_PREFIX_PATH= /home/liu/software/root/cmake/ -- The C compiler identification is GNU 11.4.0 -- The CXX compiler identification is GNU 11.4.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found Git: /usr/bin/git (found version "2.34.1") -- Found X11: /usr/include
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so -- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found Vdt: /home/liu/software/root/include (found version "0.4") -- Found Python: /home/liu/anaconda3/bin/python3.9 (found version "3.9.13") found components: Interpreter CONFIGURE_LOGPython version found is 3.9.13 and not 2.7, GUI won't be active Got user provided ROOT_CXX_VERSION=17 C++ version set to: 17
ENV(CMAKE_EXPORT_COMPILE_COMMANDS) NOT DEFINED -- Configuring done -- Generating done -- Build files have been written to: /home/liu/GRSISort-4/GRSISort-build`
[ 45%] Building CXX object _deps/grsidata-build/CMakeFiles/GTZeroDegree.dir/GTZeroDegree.cxx.o [ 45%] Built target G__TZeroDegree [ 45%] Building CXX object _deps/grsidata-build/CMakeFiles/TZeroDegree.dir/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegree.cxx.o [ 46%] Building CXX object _deps/grsidata-build/CMakeFiles/TZeroDegree.dir/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx.o /home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx: In member function ‘bool TZeroDegreeHit::AnalyzeWaveform()’: /home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx:138:35: error: ‘WaveSize’ was not declared in this scope 138 | for(size_t i = 0; i < 8 && i < WaveSize(); ++i) { | ^&)’:
/home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx:182:33: error: ‘WaveSize’ was not declared in this scope
182 | if(static_cast(WaveSize()) > delay + 1) {
| ^ TZeroDegreeHit::CalculateSmoothedWaveform(unsigned int)’:
/home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx:239:75: error: ‘WaveSize’ was not declared in this scope
239 | smoothedWaveform(std::max(static_cast(0), WaveSize() - 2 * halfsmoothingwindow),
| ^
~~~ /home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx:141:36: error: ‘WaveSize’ was not declared in this scope 141 | for(size_t i = 8; i < 16 && i < WaveSize(); ++i) { | ^~~~ /home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx:144:26: error: ‘WaveSize’ was not declared in this scope 144 | for(size_t i = 0; i < WaveSize(); ++i) { | ^~~~ /home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx: In member function ‘Int_t TZeroDegreeHit::CalculateCfdAndMonitor(double, unsigned int, int, unsigned int, std::vector~~~ /home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx: In member function ‘std::vector~~~/home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx: In member function ‘std::vector TZeroDegreeHit::CalculatePartialSum()’:
/home/liu/GRSISort-4/GRSISort-build/_deps/grsidata-src/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx:283:35: error: ‘WaveSize’ was not declared in this scope
283 | std::vector partialSums(WaveSize(), 0);
| ^
~~~ make[2]: [_deps/grsidata-build/CMakeFiles/TZeroDegree.dir/build.make:90: _deps/grsidata-build/CMakeFiles/TZeroDegree.dir/libraries/TGRSIAnalysis/TZeroDegree/TZeroDegreeHit.cxx.o] Error 1 make[1]: [CMakeFiles/Makefile2:3792: _deps/grsidata-build/CMakeFiles/TZeroDegree.dir/all] Error 2 make: *** [Makefile:136: all] Error 2