Improve the general code for better readability and performance.
Related Issues
Missing reference on submissions module.
Fixing bug for admin accessing submissions.
Changes Made
Challenges.ex - improvement of existing submission validation functions.
Security.ex - improvement of functions to control non-gov log
Submission.ex - adding missing reference security
Screenshots (if applicable)
NA
Checklist
[x] PR is assigned to a project: Challenge_gov Board
[x] PR is assigned to a milestone: current sprint
[x] GH issues are assigned to the PR (under Development section on the right hand side)
[x] PR is assigned a reviewer, and requires code review and approval by a teammate
~- [] New functionality is tested and all tests are green~
~- [ ] I have added unit tests for new functionality or updated existing tests for changes.~
~- [ ] I have updated the documentation/README accordingly, if necessary.~
~- [ ] If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.~
[x] If applicable, Controllers modified contain appropriate authorization plugs
[x] This PR has been reviewed by at least one other team member.
Description
Related Issues
Missing reference on submissions module. Fixing bug for admin accessing submissions.
Changes Made
Challenges.ex - improvement of existing submission validation functions. Security.ex - improvement of functions to control non-gov log Submission.ex - adding missing reference security
Screenshots (if applicable)
NA
Checklist