GSA / Challenge_platform

The GSA Challenge.gov platform for managing challenges
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

[200] Build Manage Evaluators List #243

Closed emmabjj closed 1 week ago

emmabjj commented 1 month ago

200 - Build Manage Evaluators List

112 - Delete Evaluators

74 - Enter Evaluators

Build the frontend for the manage evaluators list and the functionality. This allows a challenge manager to add an existing evaluator to a specific challenge/phase, invite a new evaluator, delete an evaluator or an invitation, resend an invitation to a pending evaluator, or resend an invitation if the challenge manager tries to add an existing evaluator invitation again.

Added tests to cover changes.

Add/delete/resend functionality

manage_evaluators

Build Manage Evaluator List, form, and delete modal

Screenshot 2024-10-29 at 11 07 18 AM Screenshot 2024-10-29 at 11 07 32 AM Screenshot 2024-10-29 at 11 07 40 AM Screenshot 2024-10-29 at 11 07 50 AM

Update header and challenge status

Screenshot 2024-10-29 at 11 02 24 AM

WAVE

Screenshot 2024-10-29 at 11 08 11 AM Screenshot 2024-10-29 at 11 08 32 AM

Form fields are required to add evaluator

Screenshot 2024-10-29 at 11 42 34 AM

Using evaluator_submission_assignments for evaluator submission count

Screenshot 2024-10-29 at 11 17 03 AM

Mobile

Screenshot 2024-10-29 at 11 52 53 AM Screenshot 2024-10-29 at 11 53 05 AM Screenshot 2024-10-29 at 1 28 09 PM
stepchud commented 3 weeks ago

There are some codeclimate failures about the ManageEvaluatorsController being too big - too many methods and too many lines. The basic issue is that there is a lot of business logic expressed in the controller. The standard approach to this would be to create a service object that encapsulates this logic and then call into that from the controller. I just watched the youtube video, it's a good overview on the what/why/how. I'm happy to discuss this approach with you when you are ready. Bonus: might be able to refactor that after_create callback into a service too. 🤞