GSA / data.gov

Main repository for the data.gov service
https://data.gov
Other
566 stars 88 forks source link

Warn dataset owners when dataset resources are HTTP; replace with HTTPS if not 404 #2985

Open mogul opened 3 years ago

mogul commented 3 years ago

User Story

In order to maintain trust and accessibility of datasets we index (by preventing browser warnings), we want to ensure catalog.data.gov doesn't generate mixed http/https content.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

Background

https://blog.chromium.org/2020/02/protecting-users-from-insecure.html

Lynda reported this. https://catalog.data.gov/dataset/fws-critical-habitat-for-threatened-and-endangered-species-datasetd55fc Links to http resources, and chrome (and other modern web browsers) will block these downloads.

Example of the problem (at the time of issue creation): http://ecos.fws.gov/docs/crithab/crithab_all/crithab_all_layers.zip http://ecos.fws.gov/docs/crithab/crithab_all/crithab_all_shapefiles.zip

Security Considerations (required)

This change prevents catalog.data.gov from ever presenting mixed-content.

Sketch

[Notes or a checklist reflecting our understanding of the selected approach] Note the upstream issue we filed.

jbrown-xentity commented 1 year ago

Related to #3974 and #3476

hkdctol commented 1 year ago

Archiving for now