search

GSA / px-benefit-finder

1 stars 1 forks source link

New class selector causes inaccessible contrast on selected accordions #1411

Closed scottqueen-bixal closed 5 months ago

scottqueen-bixal commented 5 months ago

What's expected

selected accordions have a background value of #1a4480

Image

What happened

#main-content .usa-accordion__button[aria-expanded=true]:not(.bg-secondary) is adding the value of #c9c9c9 when selected

Image

How to replicate

navigate to PROD benefits results

select an accordion

scottqueen-bixal commented 5 months ago

looks like it was introduced a few weeks ago

https://github.com/usagov/usagov-2021/blame/eafd3ae259177b4f9de7dc2b42106da1f15906dc/web/themes/custom/usagov/sass/_uswds-theme-custom-styles.scss#L758-L760

scottqueen-bixal commented 5 months ago

confirming contrast ratio report is failing

Image

scottqueen-bixal commented 5 months ago

usagov pr here https://github.com/usagov/usagov-2021/pull/1624

scottqueen-bixal commented 5 months ago

confirming this has been resolved on production

Image